fix(onchain): allow no-auth remote signer for the local demo#17
Merged
Conversation
go-livepeer now refuses to start a -remoteSigner on a public -httpAddr without -remoteSignerWebhookUrl (livepeer/go-livepeer#3959). The signer binds to 0.0.0.0 so the host can reach it, so add -remoteSignerAllowNoAuth to boot the local demo, with a comment that production should authorize callers via the webhook instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-livepeer#3959 makes the remote signer fail-closed: a
-remoteSigneron a public (non-loopback)-httpAddrnow refuses to start unless-remoteSignerWebhookUrlis set or-remoteSignerAllowNoAuthis passed. Our signer binds to0.0.0.0:7936so the host can reach it, so it now won't boot.Adds
-remoteSignerAllowNoAuthtocompose.onchain.ymlwith a comment flagging it as local-demo only — production should authorize callers via-remoteSignerWebhookUrlinstead.Error this fixes: