adding termination error logging #569
Open
+55
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
approved these changes
Jan 22, 2026
Comment on lines
+1133
to
1141
| go func() { | ||
| time.Sleep(5 * time.Minute) | ||
| if !c.terminated.Load() { | ||
| c.mon.CallTerminationFailure() | ||
| c.log().Errorw("call failed to terminate after 5 minutes", nil) // To be able to get call IDs | ||
| } | ||
| }() | ||
|
|
||
| ctx = context.WithoutCancel(ctx) |
Contributor
There was a problem hiding this comment.
Suggested change
| go func() { | |
| time.Sleep(5 * time.Minute) | |
| if !c.terminated.Load() { | |
| c.mon.CallTerminationFailure() | |
| c.log().Errorw("call failed to terminate after 5 minutes", nil) // To be able to get call IDs | |
| } | |
| }() | |
| ctx = context.WithoutCancel(ctx) | |
| ctx = context.WithoutCancel(ctx) // do not timeout | |
| ctx, cancel := context.WithCancel(ctx) | |
| defer cancel() | |
| go func() { | |
| select { | |
| case <-ctx.Done(): | |
| return | |
| case <-time.After(5 * time.Minute): | |
| if !c.terminated.Load() { | |
| c.mon.CallTerminationFailure() | |
| c.log().Errorw("call failed to terminate after 5 minutes", nil) // To be able to get call IDs | |
| } | |
| } | |
| }() |
We shouldn't block a goroutine unconditionally, it should also select on the context of the parent call.
Also, this should be after the CAS on c.done, so that we don't run an extra goroutine if Close is called twice.
| } | ||
|
|
||
| c.cancel() | ||
| c.terminated.Store(true) |
|
|
||
| func (c *outboundCall) stopSIP(ctx context.Context, reason string) { | ||
| go func() { | ||
| time.Sleep(5 * time.Minute) |
Contributor
There was a problem hiding this comment.
Same here, we shouldn't block unconditionally.
| } | ||
|
|
||
| func (c *CallMonitor) CallTerminationFailure() { | ||
| c.m.callsTerminationFailures.With(c.labels(prometheus.Labels{})).Inc() |
Contributor
There was a problem hiding this comment.
Suggested change
| c.m.callsTerminationFailures.With(c.labels(prometheus.Labels{})).Inc() | |
| c.m.callsTerminationFailures.With(c.labels(nil)).Inc() |
| Name: "calls_termination_failures", | ||
| Help: "Number of calls that failed to terminate after 5 minutes", | ||
| ConstLabels: prometheus.Labels{"node_id": conf.NodeID}, | ||
| }, []string{"dir"})) |
Contributor
There was a problem hiding this comment.
Calling c.labels will add to as well, which is not defined here. This will likely panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.