fix(outbound): send SIP CANCEL for early dialogs when closing #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
Close()only sent BYE for answered calls (wheninviteOk != nil) but simply dropped state for ringing calls without sending any SIP signaling. This left the far-end device ringing indefinitely.Problem
When an outbound call is terminated while in "ringing" state (early dialog - after INVITE sent but before final response received), the remote party's phone continues ringing because no SIP signaling was sent to cancel the call.
Solution
Per RFC 3261 Section 9.1, a UAC should send CANCEL to terminate an early dialog. This change:
sendCancel()method that creates CANCEL usingsip.NewCancelRequest()NewCancelRequesthandles this)Close()to callsendCancel()when invite exists but inviteOk is nilChanges
sendCancel(ctx context.Context)method tosipOutboundClose()to detect early dialog state and send CANCEL appropriately