Skip to content

Cleanup libwebrtc compiler warnings#1236

Open
OlympusM wants to merge 5 commits into
livekit:mainfrom
OlympusM:cleanup-libwebrtc-warnings
Open

Cleanup libwebrtc compiler warnings#1236
OlympusM wants to merge 5 commits into
livekit:mainfrom
OlympusM:cleanup-libwebrtc-warnings

Conversation

@OlympusM

@OlympusM OlympusM commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Small cleanup PR. Fixes a handful of compiler warnings in the libwebrtc crate:

  • Removed some unused imports in audio_source.rs and simplified the NativeAudioSource type reference
  • Dropped an unneeded unsafe block in apm.rs
  • Added an explicit lifetime to get_audio_frame_with_info in audio_mixer.rs
  • Gated the unused Generic desktop capturer variant behind macOS/Linux cfgs, removed an unneeded mut, and simplified how allow_sck_system_picker gets set

@OlympusM OlympusM requested a review from cloudwebrtc as a code owner July 9, 2026 17:02

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@OlympusM OlympusM marked this pull request as draft July 9, 2026 17:07
@OlympusM OlympusM marked this pull request as ready for review July 9, 2026 17:42
@OlympusM OlympusM requested a review from ladvoc as a code owner July 9, 2026 17:42
Comment thread libwebrtc/src/native/desktop_capturer.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants