Skip to content

Add e2e signalling tests #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasIO wants to merge 3 commits into
base: main
Choose a base branch
from
+531 −0
Open

Add e2e signalling tests #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19d0898
add e2e signalling tests
lukasIO Jul 9, 2026
31e5fbf
Merge branch 'main' into lukas/signalling-spec
lukasIO Jul 9, 2026
db6a4be
fix build
lukasIO Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions livekit-api/src/signal_client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
mod region_url_provider;
mod signal_stream;

#[cfg(all(test, feature = "signal-client-tokio", feature = "access-token"))]
mod signal_test;

pub use region_url_provider::RegionUrlProvider;

pub type SignalEmitter = mpsc::UnboundedSender<SignalEvent>;
Expand Down Expand Up @@ -1017,7 +1020,7 @@
/// in `send`. The stream slot is None so any actual write would be dropped,
/// which is fine — these tests only assert which side of the queue each
/// message lands on.
fn make_stub_inner() -> Arc<SignalInner> {

Check warning on line 1023 in livekit-api/src/signal_client/mod.rs

View workflow job for this annotation

GitHub Actions / livekit-api (signal-client (async), cargo test -p livekit-api --no-default-features --features si... 

function `make_stub_inner` is never used
Arc::new(SignalInner {
stream: AsyncRwLock::new(None),
token: Mutex::new(String::new()),
Expand Down
Loading
Loading