Skip to content

ReadyForRoomEvent #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephen-derosa wants to merge 2 commits into
base: main
Choose a base branch
from
+40 −28
Open

ReadyForRoomEvent #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
395fe98
ReadyForRoomEvent
stephen-derosa May 20, 2026
0b4d9f0
fix import order
lukasIO May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/livekit-rtc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@
"dependencies": {
"@datastructures-js/deque": "1.0.8",
"@livekit/mutex": "^1.0.0",
"@livekit/rtc-ffi-bindings": "0.12.59",
"@livekit/typed-emitter": "^3.0.0",
"@livekit/rtc-ffi-bindings": "0.12.56",
"pino": "^9.0.0",
"pino-pretty": "^13.0.0"
},
"devDependencies": {
"@bufbuild/protobuf": "^1.10.1",
"@types/node": "^22.13.10",
"vitest": "^3.0.0",
"livekit-server-sdk": "workspace:*",
"prettier": "^3.0.3",
"tsup": "^8.3.5",
"typescript": "5.8.2",
"livekit-server-sdk": "workspace:*"
"vitest": "^3.0.0"
},
"engines": {
"node": ">= 18"
Expand Down
10 changes: 10 additions & 0 deletions packages/livekit-rtc/src/room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
RoomOptions as FfiRoomOptions,
type IceServer,
IceTransportType,
type ReadyForRoomEventResponse,
type RoomInfo,
type SimulateScenarioCallback,
type SimulateScenarioKind,
Expand Down Expand Up @@ -326,6 +327,15 @@ export class Room extends (EventEmitter as new () => TypedEmitter<RoomCallbacks>
}
}
this.updateConnectionState(ConnectionState.CONN_CONNECTED);
// Release the FFI room event gate after our listener and local state are ready.
FfiClient.instance.request<ReadyForRoomEventResponse>({
message: {
case: 'readyForRoomEvent',
value: {
roomHandle: this.ffiHandle.handle,
},
},
});
break;
case 'error':
default:
Expand Down
52 changes: 27 additions & 25 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading