sdk compositing#1195
Draft
frostbyte73 wants to merge 2 commits into
Draft
Conversation
sivapolisetty
added a commit
to sivapolisetty/egress
that referenced
this pull request
May 1, 2026
PR livekit#1195's enable_template_sdk: true config flag wires GStreamer compositor source (no Chrome) ONLY for RequestTypeTemplate (offline ExportReplay). For our use case — live RoomComposite recording during events — we need the same SDK compositor path. Mirrors the existing block at line 447-449 for RequestTypeTemplate.
sivapolisetty
added a commit
to sivapolisetty/egress
that referenced
this pull request
May 2, 2026
PR livekit#1195's draft compositor path missed videorate normalization for the decoded-video case. Each track's appsrc emitted variable framerate caps (VP9 from mobile often arrives at 60fps, desktop at 30fps); the compositor downstream wants fixed framerate, so find_best_format failed across pads when more than one track was added. Symptom in our tests: multi-participant recordings showed only the first track. Egress logs had: [videoaggregator warning] gst_video_aggregator_find_best_format: Nothing compatible with video/x-raw, format=I420, ..., framerate=60/1 followed by sustained 'buffer full, dropping sample' for the 2nd track. Fix: when compositing, always insert videorate before the appsrc bin's final capsfilter, and always include the framerate constraint in the caps. The non-compositing path (single-track or raw passthrough) keeps its original behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.