Skip to content

docker base image for faster builds #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephen-derosa wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docker base image for faster builds #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b02ce20
docker base image
stephen-derosa Apr 10, 2026
aa34226
Apply suggestions from code review
stephen-derosa Apr 10, 2026
37c1b0f
Update .github/workflows/builds.yml to use TARGETARCH
stephen-derosa Apr 10, 2026
d610099
Update .github/workflows/builds.yml to use TARGETARCH
stephen-derosa Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ on:
- build.cmd
- vcpkg.json
- CMakePresets.json
- docker/Dockerfile
- docker/Dockerfile.base
- docker/Dockerfile.sdk
- .github/workflows/**
pull_request:
branches: ["main"]
Expand All @@ -29,7 +30,8 @@ on:
- build.cmd
- vcpkg.json
- CMakePresets.json
- docker/Dockerfile
- docker/Dockerfile.base
- docker/Dockerfile.sdk
- .github/workflows/**
workflow_dispatch:

Expand Down Expand Up @@ -306,6 +308,7 @@ jobs:
docker-build-x64:
name: Build (docker-linux-x64)
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'

steps:
- name: Checkout (with submodules)
Expand All @@ -325,17 +328,21 @@ jobs:
docker-images: true
swap-storage: true

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1
- name: Build base Docker image
run: |
docker build \
--build-arg TARGETARCH=amd64 \
-t livekit-cpp-sdk-base-x64:${{ github.sha }} \
-f docker/Dockerfile.base \
docker

- name: Build Docker image
- name: Build SDK Docker image
run: |
docker buildx build \
--platform linux/amd64 \
--load \
docker build \
--build-arg BASE_IMAGE=livekit-cpp-sdk-base-x64:${{ github.sha }} \
-t livekit-cpp-sdk-x64:${{ github.sha }} \
. \
-f docker/Dockerfile
-f docker/Dockerfile.sdk

- name: Verify installed SDK inside image
run: |
Expand All @@ -356,6 +363,7 @@ jobs:
docker-build-linux-arm64:
name: Build (docker-linux-arm64)
runs-on: ubuntu-24.04-arm
if: github.event_name == 'pull_request'

steps:
- name: Checkout (with submodules)
Expand All @@ -375,17 +383,21 @@ jobs:
docker-images: true
swap-storage: true

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1
- name: Build base Docker image
run: |
docker build \
--build-arg TARGETARCH=arm64 \
-t livekit-cpp-sdk-base-arm64:${{ github.sha }} \
-f docker/Dockerfile.base \
docker

- name: Build Docker image
- name: Build SDK Docker image
run: |
docker buildx build \
--platform linux/arm64 \
--load \
docker build \
--build-arg BASE_IMAGE=livekit-cpp-sdk-base-arm64:${{ github.sha }} \
-t livekit-cpp-sdk:${{ github.sha }} \
. \
-f docker/Dockerfile
-f docker/Dockerfile.sdk

- name: Verify installed SDK inside image
run: |
Expand All @@ -407,6 +419,7 @@ jobs:
name: Build (cpp-example-collection-linux-arm64)
runs-on: ubuntu-24.04-arm
needs: docker-build-linux-arm64
if: github.event_name == 'pull_request'

steps:
- name: Download Docker image artifact
Expand All @@ -433,6 +446,7 @@ jobs:
name: Build (cpp-example-collection-x64)
runs-on: ubuntu-latest
needs: docker-build-x64
if: github.event_name == 'pull_request'

steps:
- name: Download Docker image artifact
Expand Down
Loading
Loading