-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(realtime): add response-level retry and recovery for generate_reply #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Fallback adapter does not forward 'session_reconnecting' or set reconnecting state The new
This is likely acceptable today because the fallback adapter handles reconnection via model-swap rather than socket-level reconnection, and the retry loop gracefully handles the (Refers to lines 57-65) Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 New reconnecting event not forwarded through the fallback adapter, so wrapper consumers never see it The new "session_reconnecting" event is not included in the forwarded-events list ( Impact: Any code subscribing to the "session_reconnecting" event on a fallback-adapter session silently receives nothing, breaking observability of reconnection state. The forwarded-events list includes "session_reconnected" but omits the new counterpartThe PR adds (Refers to lines 57-65) Was this helpful? React with 👍 or 👎 to provide feedback. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -383,10 +383,7 @@ async def _main_task(self) -> None: | |
| self._msg_ch = utils.aio.Chan[bytes]() | ||
|
|
||
| if restart_wait_task in done: | ||
| self.emit( | ||
| "session_reconnected", | ||
| llm.RealtimeSessionReconnectedEvent(), | ||
| ) | ||
| self._set_reconnected() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 NVIDIA plugin calls _set_reconnected() without prior _set_reconnecting() The NVIDIA plugin calls Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| except Exception as e: | ||
| logger.error(f"PersonaPlex WebSocket error: {e}", exc_info=True) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.