-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(voice): add UserTurnLimitOptions to interrupt long user speech #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6d0e3fc
wip
longcw 5e4134f
clean up
longcw 9395c78
add tests
longcw 80596a0
feat(voice): add UserTurnLimitOptions to interrupt long user speech
longcw 7d931e4
Merge remote-tracking branch 'origin/main' into longc/user-speech-exc…
longcw fb3b396
fix ruff
longcw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -230,6 +230,20 @@ class SpeechCreatedEvent(BaseModel): | |
| created_at: float = Field(default_factory=time.time) | ||
|
|
||
|
|
||
| class UserTurnExceededEvent(BaseModel): | ||
| type: Literal["user_turn_exceeded"] = "user_turn_exceeded" | ||
| transcript: str | ||
| """Transcript from the current (uncommitted) user turn only. | ||
| Previous turns in the accumulation window are already in the chat context.""" | ||
| accumulated_transcript: str | ||
| """Full transcript since the start of user speaking.""" | ||
| accumulated_word_count: int | ||
| """Total word count since the start of user speaking.""" | ||
| duration: float | ||
| """Duration of the user turn in seconds.""" | ||
| created_at: float = Field(default_factory=time.time) | ||
|
Comment on lines
+233
to
+244
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're committing the turn to the chat_context, should we just give a reference to llm.ChatMessage?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah that sounds good |
||
|
|
||
|
|
||
| class ErrorEvent(BaseModel): | ||
| model_config = ConfigDict(arbitrary_types_allowed=True) | ||
| type: Literal["error"] = "error" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it should be a new overridable, vs a new event inside the AgentSession
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs to be a overridable if we want to have a default behavior like now.