Skip to content

🛠 Fix: Properly retrieve exceptions after graceful task cancellation #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gigaverse-oz wants to merge 4 commits into from
+13 −0
Closed

🛠 Fix: Properly retrieve exceptions after graceful task cancellation #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05eed8f
fix(utils.aio.utils)
gigaverse-oz Apr 14, 2025
e478195
Create changeset-23d9c87a.md
gigaverse-oz Apr 14, 2025
c16e91c
style(agents.utils.aio.utils): Run ruff
gigaverse-oz Apr 14, 2025
a848a22
style(changeset-23d9c87a.md): Delete icons
gigaverse-oz Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/next-release/changeset-23d9c87a.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-agents": patch
---

Fix: Properly retrieve exceptions after graceful task cancellation (#1991)
8 changes: 8 additions & 0 deletions livekit-agents/livekit/agents/utils/aio/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ async def cancel_and_wait(*futures: asyncio.Future):
_, cb = waiters[i]
fut.remove_done_callback(cb)

# ✅ NEW: Safely retrieve exceptions to silence warnings
for fut in futures:
if fut.done():
try:
_ = fut.exception()
except Exception:
pass # Exception already retrieved or not present


def _release_waiter(waiter, *_):
if not waiter.done():
Expand Down
Loading