Skip to content

improve aec accuracy #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theomonnom merged 8 commits into from
Mar 31, 2025
Merged

improve aec accuracy #1821

theomonnom merged 8 commits into from
Mar 31, 2025

Conversation

@theomonnom
Copy link
Member

@theomonnom theomonnom commented Mar 30, 2025

opening this PR rn to test the changesets CI

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2025 •
edited
Loading

❌ Invalid Changeset Format Detected

One or more changeset files in this PR have an invalid format. Please ensure they adhere to:

  • Start with --- and include a closing --- on its own line.
  • Each package line must be in the format:
    "package-name": patch|minor|major
  • No duplicate package entries allowed.
  • A non-empty change description must follow the front matter.

Error details:
.github/next-release/changeset-1185ca82.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-23110904.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-2618f076.md: Failed to read file from git branch 'pr_head'.
.github/next-release/changeset-b5676ad3.md: Failed to read file from git branch 'pr_head'.

@theomonnom
Copy link
Member Author

theomonnom commented Mar 30, 2025 •
edited
Loading

will depends on livekit/rust-sdks#616 & livekit/python-sdks#404

@theomonnom theomonnom requested a review from a team March 31, 2025 12:31
@theomonnom theomonnom changed the title fix aec improve aec accuracy Mar 31, 2025
longcw
longcw approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@longcw longcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@theomonnom theomonnom merged commit 27195a6 into main Mar 31, 2025
5 of 6 checks passed
@theomonnom theomonnom deleted the theo/fix-aec branch March 31, 2025 15:25
@longcw
Copy link
Contributor

longcw commented Mar 31, 2025

I think we need to release a new version of python-sdk and update the dep in agents.

@theomonnom
Copy link
Member Author

theomonnom commented Mar 31, 2025

right, will do rn

@theomonnom theomonnom restored the theo/fix-aec branch April 1, 2025 10:14
jayesh-mivi pushed a commit to mivi-dev-org/custom-livekit-agents that referenced this pull request Jun 4, 2025
@theomonnom
improve aec accuracy (livekit#1821)
a8ccdaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longcw longcw longcw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theomonnom @longcw