Port expressive mode example cleanup#2012
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No code changes are required for parity with livekit/agents#6370 because agents-js does not expose expressive mode, expressive presets, or expressive example configuration.
Verification
pnpm buildpnpm lint(completed successfully; existing warnings were reported)Source diff coverage
examples/drive-thru/agent.pyexamples/src/drive-thru/drivethru_agent.tsdoes not import or configure expressive mode.examples/frontdesk/agent.pyexamples/src/frontdesk/frontdesk_agent.tsdoes not import or configure expressive mode.examples/healthcare/agent.pyexamples/inference/agent.pyexamples/survey/agent.pyexamples/src/survey_agent.tsdoes not import or configure expressive mode.livekit-agents/livekit/agents/voice/__init__.pyagents/src/voice/index.tsdoes not export expressive options or presets.livekit-agents/livekit/agents/voice/agent.pyagents/src/voice/agent.tshas noexpressiveagent option or getter.livekit-agents/livekit/agents/voice/agent_activity.pyagents/src/voice/agent_activity.tshas no expressive resolution or TTS markup injection path.livekit-agents/livekit/agents/voice/agent_session.pyagents/src/voice/agent_session.tshas noexpressivesession option or internal expressive state.livekit-agents/livekit/agents/voice/presets.pyvoice/presetsmodule or expressive preset API.Ported from livekit/agents#6370
Original PR description
Remove the user-facing expressive surface while keeping the pipeline machinery internal and disabled:
expressiveparam from AgentSession and Agent (and the Agent.expressive property)expressivefield from AgentSessionOptions_expressive = False, which AgentActivity._resolve_expressive_options() now reads, so the markup/presets machinery stays intact but always resolves disabledexpressive=presets.*usage from the examples