feat(anam): add director notes config#1973
Conversation
🦋 Changeset detectedLatest commit: 7b9f074 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| // Only forward the avatar model version when set; otherwise let Anam | ||
| // fall back to the avatar's default model. | ||
| ...(pc.avatarModel ? { avatarModel: pc.avatarModel } : {}), | ||
| ...(directorNotes && Object.keys(directorNotes).length > 0 ? { directorNotes } : {}), | ||
| }; |
There was a problem hiding this comment.
🔍 directorNotes silently ignored when personaId is provided
When a user provides both personaId and directorNotes in their PersonaConfig, the directorNotes are silently dropped at plugins/anam/src/api.ts:143-144 because the personaId branch only sends { personaId: pc.personaId }. This is consistent with how avatarModel, name, and avatarId are also excluded in the personaId path, and the type comment at plugins/anam/src/types.ts:22 labels directorNotes as "(prod flow)" (i.e. ephemeral only). However, unlike the other fields which are clearly about defining a persona from scratch, directorNotes reads more like a per-session override that could plausibly apply to a pre-existing persona too. If the Anam API supports director notes as session-level overrides for stateful personas, this would need to be included in the personaId branch as well.
(Refers to lines 143-154)
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
DirectorNotesconfig to the Anam pluginVerification
pnpm --filter @livekit/agents buildpnpm --filter @livekit/agents-plugin-anam buildpnpm --filter @livekit/agents-plugin-anam api:updatepnpm --filter @livekit/agents-plugin-anam api:checkpnpm --filter @livekit/agents-plugin-anam lint(passes with existing warnings insrc/avatar.test.ts)Ported from livekit/agents#6267
Original PR description
What
Adds support for director notes config for Anam avatars.
Director notes allow the user to configure avatar expressivity through a preset or custom style and a expressivity slider. Only applicable to avatars using the new Cara 4 model.
Why
Gives the user control over how their avatar feels and reacts
Design