fix(generation): preserve LLM-supplied call_id instead of overwriting with item id#1524
Open
toubatbrian wants to merge 2 commits into
Open
fix(generation): preserve LLM-supplied call_id instead of overwriting with item id#1524toubatbrian wants to merge 2 commits into
toubatbrian wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a6fa864 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6fa86460f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
voice/generation.tswas overwriting the LLM-suppliedcallIdwith the generation's per-item UUID. Python keeps these two identifiers distinct (id= framework item id,call_id= the LLM's identifier that pairsfunction_call↔function_call_output). This change restores that separation, matchinglivekit-agents/.../generation.py:170-176.Also fixes
examples/src/testing/basic_task_group.test.ts > summarizeChatCtx, which was failing because itsFakeLLMmock used the old pre-XML prompt format and[history summary]literal. Updated to match whatChatContext._summarizeactually emits; now deterministic sincefake_call_0survives end-to-end.Why this matters
Downstream providers (OpenAI, Anthropic, Gemini, etc.) emit their own
tool_call_idthat we must echo back infunction_call_outputso the provider can correlate the call. Overwriting it silently inverted the invariant from Python.Test plan
pnpm build:agents && pnpm vitest run examples/src/testing examples/src/frontdesk/test_agent.test.ts examples/src/drive-thru/test_agent.test.ts— 75/75 pass (was 74/75)pnpm test— no new regressions; remaining failures (AMD logic, plugin TTS VAD setup, missing API keys) reproduce onmain