feat: add category nav component#29
Conversation
| return <ClientReactions roomId={ROOM_ID} serverReactions={reactions} />; | ||
| } | ||
| // return <ClientReactions roomId={ROOM_ID} serverReactions={reactions} />; | ||
| // } |
There was a problem hiding this comment.
- Will uncomment all of this before squashing for merge
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| <ReactionsList {...props}> | ||
| <Suspense fallback={<FallbackReactions />}> | ||
| <ServerReactions /> | ||
| {/* <ServerReactions /> */} |
There was a problem hiding this comment.
Bug: Commented-out code accidentally committed for testing
The liveblocks client initialization and ServerReactions component are commented out, and the component usage in the Suspense block is replaced with a comment. The PR description explicitly mentions this was done for local testing ("Currently have to comment out the <ServerReactions /> component and LiveblocksClient() to test things"). With the actual component commented out, the Suspense children render as nothing, so users will see no content where the reactions component should appear.
|
Small ping @marcbouchenoire about this - would just need input on where to source the SVG icons and if you have any preference for them (we can also just keep the icons for the demo only and otherwise always leave it up to the user to provide them for true composability) |
Overview
Hi team, just wanted to get the ball rolling with the implementation for #7
Very much a rough draft atm, would just love some light guidance on which direction to take this (namely sourcing the icons)
@marcbouchenoire
Screen.Recording.2025-12-15.at.11.32.55.mov
Discussion points
site/src/components/reactions.tsxconfigurable locally, so the Liveblocks key wouldn't be necessary? Currently have to comment out the<ServerReactions />component andLiveblocksClient()to test things<EmojiPickerPrimitive.CategoryNav />& we could remove the need to pass any childrenMarket research
Note
Introduces
EmojiPicker.CategoryNavwith scrolling to categories, updates examples to use it, and disables server reactions in the site for local testing.CategoryNav: ImplementsEmojiPicker.CategoryNavexposing categories withscrollTohandlers.EmojiPickerCategoryNavPropsand related render props; re-exports fromsrc/index.ts.CategoryNavinto usage examples (site/src/examples/usage/*).site/src/components/reactions.tsx.site/next-env.d.tsto./.next/dev/types/routes.d.ts.Written by Cursor Bugbot for commit 4a5de18. This will update automatically on new commits. Configure here.