feat: add SHA-256 contentAddress to identity document#9
Merged
Conversation
Computes SHA-256 over the same JCS-canonicalized bytes used for the
Ed25519 signature and appends contentAddress {alg, digest} to the
document. contentAddress is added to _OUT_OF_SCOPE_KEYS so verify_identity
strips it before canonicalization, keeping verification deterministic.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GRuyRG2kcHdKwtrqdwMZAK
generate_identity_document() now delegates to sign_identity() instead of repeating the private-key load and Ed25519 sign call. _OUT_OF_SCOPE_KEYS now has exactly one enforcement point. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GRuyRG2kcHdKwtrqdwMZAK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_identity_document()contentAddress: {alg: "sha256", digest: "<hex>"}to the returned documentcontentAddressto_OUT_OF_SCOPE_KEYSsoverify_identity()strips it before canonicalization — keeps verification deterministic when a full document is passedOutput example
No new canonicalization step — reuses
canonical_dataalready computed for signing.Test plan
generate_identity_document()returnscontentAddresswithalganddigestdigestmatcheshashlib.sha256(jcs.canonicalize(non_proof)).hexdigest()verify_identity(doc, sig, pub)still returnsTruewhen full document (includingcontentAddress) is passedGenerated by Claude Code