Merged
Conversation
Updated test namespaces from 'Litebase\Tests' to 'Tests' for consistency and PSR-4 compliance. Refactored LitebasePDO to accept a LitebaseClient instance directly, simplifying its construction and configuration. Added a static Configuration::create method for easier configuration instantiation. Updated all affected tests and usages accordingly.
Added declare(strict_types=1); to all source and test PHP files to enforce strict type checking. Also made minor code style improvements, such as consistent spacing around concatenation operators and lambda formatting.
Introduces a configurable transport type to Configuration and LitebaseClient, including new getter/setter methods. Updates request header logic for port handling, fixes transactionId key in Connection, and enhances integration tests to cover both default and http_streaming transports, including access key creation for streaming transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings to the Litebase PHP client, focusing on stricter type safety, configuration handling, and code clarity. The most significant changes are the addition of strict typing declarations across all source files, a major refactor of the configuration and client instantiation process, and improvements to request handling and documentation.
Type Safety and Code Consistency
declare(strict_types=1);to all PHP source files, enforcing strict type checking throughout the codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Configuration and Client Initialization Refactor
Configurationclass to add a staticcreate()method for instantiating from an array, addedtransportproperty and getter/setter, and improved PHPDoc comments. [1] [2] [3]LitebasePDOto accept aLitebaseClientinstance directly, removing manual configuration handling and redundant setter methods. [1] [2]LitebaseClientto set transport type in the constructor and added/improved several methods with better documentation and null safety. [1] [2] [3] [4] [5] [6]Request Handling Improvements
HasRequestHeadersto treat port values as strings and use string formatting, improving header correctness.Connectionto usetransactionId(camelCase) instead oftransactionID(PascalCase) for response parsing, ensuring compatibility with API responses.Testing and Autoloading
autoload-devnamespace incomposer.jsonto useTests\instead ofLitebase\Tests\, aligning with standard conventions.These changes collectively improve the maintainability, reliability, and clarity of the Litebase PHP client library.