Add support for json schema string with format metadata

[JohanCodinha]

No description provided.

[JohanCodinha]

This could use uri?

[lispyclouds]

can we test it a bit in a reitit server to see what type the coercion produces?

[JohanCodinha]

bytes?

[lispyclouds]

same for this, test coercion in the server

[lispyclouds]

thanks for this, will have a look later today or by tomorrow!

[lispyclouds]

@john-shaffer can i ask a favour of you to maybe test these changes with the 3.1.0 samples you have too? this would greatly help me out. @JohanCodinha can we also add the yamls to the repo too? we should run the full parse test i feel.

[JohanCodinha]

Have a look here, let me know if you like that way of testing I can add it here too.

[lispyclouds]

@JohanCodinha yes, lets get some of the yamls in here too like that.

[lispyclouds]

we can make this private

[lispyclouds]

date and date-time can use inst?

[lispyclouds]

maybe this needs a transform date-time fn too when #11 comes in

[lispyclouds]

We have #11 merged now, can use the date schemas from that.

[john-shaffer]

@john-shaffer can i ask a favour of you to maybe test these changes with the 3.1.0 samples you have too? this would greatly help me out. @JohanCodinha can we also add the yamls to the repo too? we should run the full parse test i feel.

Sure. I tested the changes in my app with good results. Not only does this patch work well, it pinpointed a bug in my app.

[lispyclouds]

That's awesome to hear @john-shaffer

[john-shaffer]

Regarding date and date-time formats, my app handles this by parsing the strings that come in from reitit. AFAIK all {:type "string"} objects come in to the handlers as Strings regardless of the format.

[lispyclouds]

right, so with this change if we use inst? the coercion would change it to an Instant if the format is date or date-time. reitit can then check the string for you too when it gets it from the api

[john-shaffer]

Thanks, I'm not very familiar with malli coercion. I tested with "date-time" inst? and the results were as expected. date-time values are passed to handlers as java.util.Dates, and Dates returned from handlers are coerced to strings in the correct format.

[lispyclouds]

@JohanCodinha i think if you could add in the tests, I can follow up with the rest of the changes myself 😄