Fix Voronoi neighbor computation and plotting compatibility with updated SciPy and NumPy#1
Open
Edhain wants to merge 2 commits intolis-epfl:mainfrom
Open
Fix Voronoi neighbor computation and plotting compatibility with updated SciPy and NumPy#1Edhain wants to merge 2 commits intolis-epfl:mainfrom
Edhain wants to merge 2 commits intolis-epfl:mainfrom
Conversation
Delaunay object in SciPy's scipy.spatial module no longer has an attribute called vertices. This attribute was deprecated in recent versions of SciPy and has been replaced by simplices.
ptp was removed from the ndarray class in NumPy 2.0. The solution is to replace vor.points.ptp(axis=0) with np.ptp(vor.points, axis=0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed AttributeError in voronoi_neighbors function: replaced tri.vertices with tri.simplices to match updated SciPy Delaunay API.
Updated voronoi_plot_2d to use np.ptp(vor.points, axis=0) instead of ptp method, aligning with changes in NumPy 2.0.
These changes resolve errors when running the --filter-voronoi option and ensure compatibility with the latest SciPy and NumPy versions.