Open
Conversation
| enabled: !!userAddress, | ||
| queryKey: ["userVotedInitiatives", userAddress], | ||
| queryFn: async () => { | ||
| const history = await getUserAllocationHistory(userAddress!); |
Collaborator
There was a problem hiding this comment.
It's not a huge deal, but technically, this duplicates the fetching of user allocation history. It could be eliminated via a useUserAllocationHistory hook, which could be used in useBribingClaim & useUserVotedInitiatives.
This is really only a concern when the subgraph is being used (not the default behavior), since by default the data will be fetched from api.liquity.org, in which case the duplicate request will find the data in the browser's cache.
danielattilasimon
approved these changes
Mar 1, 2026
Collaborator
danielattilasimon
left a comment
danielattilasimon
left a comment
There was a problem hiding this comment.
Looks good! I've started redeploying the subgraph, it'll probably take a few days to propagate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.