Add a function for expecting a panic.#6
Merged
Conversation
liquidgecka
force-pushed
the
brady/add_expect_panic
branch
from
7b7eaea to
5191dd4
Compare
liquidgecka
force-pushed
the
brady/add_expect_panic
branch
from
5191dd4 to
4959b2e
Compare
philpennock
reviewed
Jan 23, 2018
|
|
||
| // Expects the function passed in to panic. This will call f() and expect | ||
| // that an error matching err will be raised as a panic. | ||
| func (t *T) ExpectPanic(f func(), err interface{}, desc ...string) { |
Collaborator
There was a problem hiding this comment.
This shouldn't be called err, since it's not error but "whatever was panic'd"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.