Support for Let's encrypt certprofiles#607
Open
Sausageroll2077 wants to merge 5 commits intolinuxserver:masterfrom
Open
Support for Let's encrypt certprofiles#607Sausageroll2077 wants to merge 5 commits intolinuxserver:masterfrom
Sausageroll2077 wants to merge 5 commits intolinuxserver:masterfrom
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Author
|
While testing this on Unraid, I noticed every container restart was looping into a revoke + reissue cycle when CERT_PROFILE=shortlived was set. The cause is the existing legacy check that tries to detect certs still on the expired DST Root CA X3 cross-sign: I changed it to check for the actual bad chain: This way it does not interfere with the new intermediates that shortlived introduces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added support for https://letsencrypt.org/docs/profiles/ primarily for the shortlived profile since this is really the only one that currently changes things from default.
It enables the cert profile enviroment so that when certbot renews or requests a cert it will request for the "shortlived" profile a shorter certificate lifetime (6 days).
Benefits of this PR and context:
This is a new feature for letsencrypt and certbot. The whole community will be moving towards shorter certificates
and therefore swag users should be able to test or adapt early to this new reality.
How Has This Been Tested?
I have build the docker locally on my unraid server and changed the repository to this local repo.

I added the CERT_PROFILE variable with the value shortlived and ran it in staging mode and non staging mode and both times got a certificate for 6 days:
Source / References:
https://letsencrypt.org/docs/profiles/