Merged
Conversation
…wnloads are not rendered in browser
This was referenced Oct 1, 2025
Collaborator
|
I am a bot, here are the test results for this PR:
|
Collaborator
|
I am a bot, here are the test results for this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes many bugs and adds many new environment variables:
Dashboard
DASHBOARD- allows the user to set their dashboard from current options selkies-dashboard selkies-dashboard-zinc selkies-dashboard-wish.File path
FILE_MANAGER_PATH- modifies the default upload/download file pathMeta Tags
HARDEN_DESKTOP- enablesDISABLE_OPEN_TOOLSDISABLE_SUDODISABLE_TERMINALSif unset by user app settingsSELKIES_FILE_TRANSFERSSELKIES_COMMAND_ENABLEDSELKIES_UI_SIDEBAR_SHOW_FILESSELKIES_UI_SIDEBAR_SHOW_APPSHARDEN_OPENBOX- enablesDISABLE_CLOSE_BUTTONDISABLE_MOUSE_BUTTONSHARDEN_KEYBINDSand flagsRESTART_APPif unset by user as the app needs to be auto restart without any kind of launch ability.Hardening env vars
DISABLE_OPEN_TOOLS- If set, disablesxdg-openandexo-openbinaries by removing their execute permissions.DISABLE_SUDO- If set, disables thesudocommand by removing its execute permissions and invalidating the passwordless sudo configuration.DISABLE_TERMINALS- If set, disables common terminal emulators by removing their execute permissions and hiding them from the Openbox right-click menu.DISABLE_CLOSE_BUTTON- If set, removes the close button from window title bars in the Openbox window manager.DISABLE_MOUSE_BUTTONS- If set, disables the right-click and middle-click context menus and actions within the Openbox window manager.HARDEN_KEYBINDS- If set, disables default Openbox keybinds that can bypass other hardening options (e.g.,Alt+F4to close windows,Alt+Escapeto show the root menu).RESTART_APP- If set, enables a watchdog service that automatically restarts the main application if it is closed. The user's autostart script is made read-only and root owned to prevent tampering.This allows single app containers to be locked to the app, when passing like
-e HARDEN_DESKTOP=trueand-e HARDEN_OPENBOX=trueto a container it becomes a single app instance that the client really cannot change anything about the container just stay in the app sandbox.example :
This all depends on the app but stuff like chromium uses xdg-open to open files or file managers so it really is isolated down to its base function and cannot spin up random bins from its file:// url scheme. Even extensions would be forced to use that standardized api as far as I understand it.