fix: nvidia-container-toolkit missing files when mounting to Docker#91
Conversation
Because NVIDIA never does it correctly, we have to do this ourselves. - NVIDIA doesn't provide DRI3 support - NVIDIA never fixes this issue properly - NVIDIA likes to do things their own way - Top 3 public clouds are obsessed with NVIDIA, so we have no choice but to support it Ported from: https://github.com/selkies-project/docker-selkies-egl-desktop/blob/8dd03fba2a33ac774d61f46375a19ed1d9c5b51a/Dockerfile#L248-L264
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing NVIDIA graphics API configuration files when nvidia-container-toolkit doesn't properly mount all required files to Docker containers. The changes ensure consistent NVIDIA GPU support by automatically creating OpenCL, Vulkan, and EGL configuration files when they are missing.
Key changes:
- Added automatic detection and setup of NVIDIA graphics API configuration files
- Implemented fallback creation of OpenCL ICD, Vulkan ICD, and EGL vendor files
- Added dynamic Vulkan API version detection from library symlinks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
github-project-automation
bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
|
I am a bot, here are the test results for this PR:
|
Description:
Added automatic setup of NVIDIA graphics API configuration files (OpenCL, Vulkan, EGL) when they are missing or not properly mounted by nvidia-container-toolkit.
Modified init-video script to detect and create:
Benefits of this PR and context:
How Has This Been Tested?
Source / References:
https://github.com/selkies-project/docker-selkies-egl-desktop/blob/8dd03fba2a33ac774d61f46375a19ed1d9c5b51a/Dockerfile#L248-L264