Skip to content

Changed default resolution behavior to use environment variable width and height if set instead of hard coded 1024x768#113

Closed
DenTechs wants to merge 3 commits intolinuxserver:ubuntunoblefrom
DenTechs:ubuntunoble
Closed

Changed default resolution behavior to use environment variable width and height if set instead of hard coded 1024x768#113
DenTechs wants to merge 3 commits intolinuxserver:ubuntunoblefrom
DenTechs:ubuntunoble

Conversation

@DenTechs
Copy link
Copy Markdown

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changed the default resolution behavior to use environment variable width and height if set instead of the currently hard coded 1024x768, modeline is generated using CVT.

Benefits of this PR and context:

When a manual resolution is set, instead of defaulting to 1024x768 and then changing on first connect, the manual resolution is used immediately. Additionally this change prevents a bug in my firefox ffmpeg capture fork as it can't handle the resolution changing dynamically.

How Has This Been Tested?

Built and tested with my fork of firefox and confirmed that the resolution was set to the one provided by the environment file instead of the hard coded 1024x768

This change should not have any affects on other areas of the code.

Source / References:

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113/shellcheck-result.xml

Tag Passed
amd64-ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113
arm64v8-ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113/shellcheck-result.xml

Tag Passed
amd64-ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113
arm64v8-ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113

@thelamer
Copy link
Copy Markdown
Member

Sorry I keep missing this when I do weeklys I will try to get this on all branches next week.

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-40eb8435-pkg-40eb8435-dev-92d9fe7d4ca71097008d2ec66208deccf98079a9-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-40eb8435-pkg-40eb8435-dev-92d9fe7d4ca71097008d2ec66208deccf98079a9-pr-113/shellcheck-result.xml

Tag Passed
amd64-ubuntunoble-40eb8435-pkg-40eb8435-dev-92d9fe7d4ca71097008d2ec66208deccf98079a9-pr-113
arm64v8-ubuntunoble-40eb8435-pkg-40eb8435-dev-92d9fe7d4ca71097008d2ec66208deccf98079a9-pr-113

thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching, update readme regarding virtual display clamping
@thelamer
Copy link
Copy Markdown
Member

thelamer commented Dec 4, 2025

I am working through these now, sorry for not directly merging this, but I have to tweak it for every distro and have other changes to set the max_res as well (this has a performance impact)

@thelamer thelamer closed this Dec 4, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Dec 4, 2025
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
thelamer added a commit that referenced this pull request Dec 4, 2025
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants