Changed default resolution behavior to use environment variable width and height if set instead of hard coded 1024x768#113
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
Sorry I keep missing this when I do weeklys I will try to get this on all branches next week. |
|
I am a bot, here are the test results for this PR:
|
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching, update readme regarding virtual display clamping
|
I am working through these now, sorry for not directly merging this, but I have to tweak it for every distro and have other changes to set the max_res as well (this has a performance impact) |
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
…re it, fix spacebar not working for some games, #113 launch to set resolution for app, cleanup lock files for xorg and dbus before launching
Description:
Changed the default resolution behavior to use environment variable width and height if set instead of the currently hard coded 1024x768, modeline is generated using CVT.
Benefits of this PR and context:
When a manual resolution is set, instead of defaulting to 1024x768 and then changing on first connect, the manual resolution is used immediately. Additionally this change prevents a bug in my firefox ffmpeg capture fork as it can't handle the resolution changing dynamically.
How Has This Been Tested?
Built and tested with my fork of firefox and confirmed that the resolution was set to the one provided by the environment file instead of the hard coded 1024x768
This change should not have any affects on other areas of the code.
Source / References: