Skip to content

Fix NO_DECOR handler#111

Closed
crazyrokr wants to merge 1 commit intolinuxserver:masterfrom
crazyrokr:master
Closed

Fix NO_DECOR handler#111
crazyrokr wants to merge 1 commit intolinuxserver:masterfrom
crazyrokr:master

Conversation

@crazyrokr
Copy link
Copy Markdown

@crazyrokr crazyrokr commented Oct 27, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

The following code

if [[ ! -z ${NO_DECOR+x} ]]; then
echo "[ls.io-init] Removing window decorations"
sed -i '/<application class="\*">/a \ <decor>no</decor>' "$SYS_RC_XML"
fi

results in wrong OpenBox configuration:

  <application class="*"><maximized>yes</maximized></application>
    <decor>no</decor>

The PR changes move a <decor> tag into an <application> tag:

  <application class="*"><decor>no</decor><maximized>yes</maximized></application>

Benefits of this PR and context:

Current implementation doesn't allow to disable windows decoration. The PR fixes the bug.

How Has This Been Tested?

  1. A new Docker image was created on the basis of https://github.com/linuxserver/docker-obsidian
  2. A fixed version of /etc/s6-overlay/s6-rc.d/init-selkies-config/run was included to the image
  3. /config/.config/openbox/rc.xml was verified after container startup

Source / References:

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/debianbookworm-01c5c51e-pkg-01c5c51e-dev-fec283b5095739b82174095f0a9b6f249afb2b14-pr-111/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/debianbookworm-01c5c51e-pkg-01c5c51e-dev-fec283b5095739b82174095f0a9b6f249afb2b14-pr-111/shellcheck-result.xml

Tag Passed
amd64-debianbookworm-01c5c51e-pkg-01c5c51e-dev-fec283b5095739b82174095f0a9b6f249afb2b14-pr-111
arm64v8-debianbookworm-01c5c51e-pkg-01c5c51e-dev-fec283b5095739b82174095f0a9b6f249afb2b14-pr-111

thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
@thelamer
Copy link
Copy Markdown
Member

Tried to modify your branch to bump as well but edits from maintainers was not allowed. In any case in with this commit thanks 67440f8

@thelamer thelamer closed this Oct 28, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
thelamer added a commit that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants