Closed
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Collaborator
|
I am a bot, here are the test results for this PR:
|
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
Member
|
Tried to modify your branch to bump as well but edits from maintainers was not allowed. In any case in with this commit thanks 67440f8 |
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
thelamer
added a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The following code
docker-baseimage-selkies/root/etc/s6-overlay/s6-rc.d/init-selkies-config/run
Lines 147 to 150 in 3eaac97
results in wrong OpenBox configuration:
The PR changes move a
<decor>tag into an<application>tag:Benefits of this PR and context:
Current implementation doesn't allow to disable windows decoration. The PR fixes the bug.
How Has This Been Tested?
/etc/s6-overlay/s6-rc.d/init-selkies-config/runwas included to the image/config/.config/openbox/rc.xmlwas verified after container startupSource / References: