feat: match anywhere in filename during interactive search#3718
Open
KonTy wants to merge 1 commit intolinuxmint:masterfrom
Open
feat: match anywhere in filename during interactive search#3718KonTy wants to merge 1 commit intolinuxmint:masterfrom
KonTy wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Previously, type-ahead search only matched at the start of filenames. Now it matches anywhere in the filename (case insensitive). For example, typing 'demo' will now find 'preview-demo.gif'. Applies to both icon view and list view. Closes linuxmint#2660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the interactive type-ahead search (the search that activates when you start typing in a file view) to match anywhere in the filename instead of only matching from the beginning.
Changes
nemo-icon-container.c): Changedstrncmp(key, name, strlen(key))→strstr(name, key)so typing e.g. "log" matches "changelog.txt"nemo-list-view.c): Added a customsearch_equal_functhat normalizes both the search key and filename to UTF-8 NFD + casefold, then usesstrstrfor substring matchingMotivation
The prefix-only matching behavior is unintuitive — users often know part of a filename but not the exact beginning. Substring matching is the standard in most modern file managers.
Inspired by #3714