fix: cleanup mock#4266
Merged
Merged
Conversation
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a dead mock-data module from the public packages API area of the backend, reducing unused code without changing runtime behavior.
Changes:
- Deleted
backend/src/api/public/v1/packages/mockData.ts(static fixtures + related TS interfaces) that no longer has any in-repo references.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused mock
Type of change
Note
Low Risk
Pure deletion of unreferenced mock data; no production logic or API behavior is modified.
Overview
Removes
backend/src/api/public/v1/packages/mockData.ts, which defined static list/detail/metrics fixtures (MOCK_PACKAGES,MOCK_DETAILS,MOCK_METRICS) for the public packages API. Nothing in the backend still imports those symbols, so this is dead-code removal with no runtime behavior change.Reviewed by Cursor Bugbot for commit 33016d1. Bugbot is set up for automated code reviews on this repo. Configure here.