chore: expand gerrit delete activities script by joanagmaia · Pull Request #4080 · linuxfoundation/crowd.dev

joanagmaia · 2026-05-06T13:27:26Z

Summary

Replaced hardcoded type and date filters with --type and --before-date CLI flags, making the script
reusable for different cleanup scenarios without code changes.
Added a pre-flight count step that queries all three stores (Postgres, Tinybird activities, Tinybird
activityRelations) in parallel before any deletion, so the operator can see the blast radius upfront.
Added an interactive confirmation prompt (skippable with --yes/-y) to prevent accidental mass deletions.
Refactored Postgres deletion from a Tinybird-ID-driven batched approach to a direct chunked DELETE ...
WHERE ... LIMIT 10k loop, removing the dependency on Tinybird to drive the Postgres cleanup.
Added input validation for --before-date (YYYY-MM-DD format check) and --type (enum guard against
VALID_GERRIT_TYPES), with an explicit warning when neither filter is provided (would delete all Gerrit
activities).

Note

Medium Risk
Medium risk because it changes a destructive cleanup script’s deletion targeting and execution flow across Postgres and Tinybird; incorrect flags or filter construction could delete unintended data.

Overview
Expands the Gerrit activities cleanup tooling by adding a cleanup-gerrit-activities script entry and refactoring the cleanup script to accept --type and --before-date filters (with validation), plus --yes/-y to skip an interactive confirmation.

The script now performs pre-flight Tinybird row counts, warns when no filters are provided, deletes matching Postgres activityRelations via chunked 10k batches (no longer driven by Tinybird ID pagination), triggers one Tinybird delete job per datasource, and persists job IDs/status to a /tmp result file before optionally waiting for completion.

^{Reviewed by Cursor Bugbot for commit 70aca0e. Bugbot is set up for automated code reviews on this repo. Configure here.}

…es as filters Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-05-06T13:27:38Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-05-06T13:27:43Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-05-06T13:28:04Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

github-actions · 2026-05-06T13:31:53Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

github-actions · 2026-05-06T16:24:28Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

Copilot

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

github-actions · 2026-05-11T13:29:30Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4b50a8f. Configure here.}

Copilot

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Copilot

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

mbani01 · 2026-05-25T08:36:32Z

+  const fetchQuery = `SELECT "activityId" FROM "activityRelations" WHERE ${where} LIMIT ${batchSize}`
+


@joanagmaia did you test how this performs?
The main reason behind using tb to get activity IDs was performance

…ect PG delete (CM-1298) Ports safety improvements proposed in #4080 onto the parameterized script: - Split into separate Tinybird (unquoted) and Postgres (pg-promise params, "updatedAt" double-quoted) filter builders so each store gets its own dialect. - Add cheap pre-flight Tinybird count() on both datasources to show blast radius before any destructive action. - Interactive confirmation prompt with --yes / -y bypass for non-interactive runs. - Switch PG cleanup to direct chunked DELETE (fetch matching IDs from PG, delete by PK) rather than streaming IDs from Tinybird. Decouples PG cleanup throughput from Tinybird. - Extend Tinybird job wait timeout from 1h to 6h for large bulk deletes. - Persist result JSON immediately after triggering TB jobs so the job IDs survive a wait timeout. - Docstring note that derived MVs are not cascaded by raw datasource deletes. Supersedes #4080. Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

joanagmaia added 2 commits May 6, 2026 12:23

chore: expand gerrit delete activities script to include date and typ…

027258c

…es as filters Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

chore: expand gerrit delete activities script

49d849d

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

joanagmaia requested review from Copilot and mbani01 May 6, 2026 13:27

Copilot AI reviewed May 6, 2026

View reviewed changes

chore: add script run to package.json

383dede

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

cursor Bot reviewed May 6, 2026

View reviewed changes

Comment thread services/apps/script_executor_worker/src/bin/cleanup-gerrit-activities.ts Outdated

fix: lint

b7386b1

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Copilot AI review requested due to automatic review settings May 6, 2026 16:23

Copilot started reviewing on behalf of joanagmaia May 6, 2026 16:24 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Merge branch 'main' into chore/expand-gerrit-delete-activities-script

ec68782

chore: improve postgres handling

4b50a8f

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Copilot AI review requested due to automatic review settings May 11, 2026 15:51

Copilot started reviewing on behalf of joanagmaia May 11, 2026 15:51 View session

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread services/apps/script_executor_worker/src/bin/cleanup-gerrit-activities.ts

Comment thread services/apps/script_executor_worker/src/bin/cleanup-gerrit-activities.ts

Copilot AI reviewed May 11, 2026

View reviewed changes

joanagmaia added 2 commits May 11, 2026 17:07

fix: lint

8dd1936

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Merge branch 'main' into chore/expand-gerrit-delete-activities-script

70aca0e

Copilot AI review requested due to automatic review settings May 12, 2026 10:31

Copilot started reviewing on behalf of joanagmaia May 12, 2026 10:32 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

mbani01 reviewed May 25, 2026

View reviewed changes

joanagmaia mentioned this pull request Jun 26, 2026

fix: classify merged gitlab MRs as MERGE_REQUEST_MERGED (CM-1298) #4271

Merged

4 tasks

		const fetchQuery = `SELECT "activityId" FROM "activityRelations" WHERE ${where} LIMIT ${batchSize}`

Uh oh!

Conversation

joanagmaia commented May 6, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mbani01 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joanagmaia commented May 6, 2026 •

edited by cursor Bot

Loading