fix(debian): avoid restarting treeland on upgrade#929
Merged
Conversation
treeland.service is managed by DDM at runtime, but the package installs it as a systemd system unit. With the default dh_installsystemd behavior, debhelper generates maintainer script snippets that can start or restart the unit during package install and upgrade. That makes upgrading the treeland package disrupt the active compositor/greeter session.
Override dh_installsystemd with --no-start and --no-stop-on-upgrade so package operations do not change the running treeland.service state. DDM remains responsible for explicitly starting and stopping the compositor.
Also add the missing ${misc:Depends} substitutions and normalize the treeland-dev dependency formatting so debhelper-generated dependencies are preserved in the binary package metadata.
PMS: 364327
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Debian packaging so treeland.service is not automatically started or restarted during install/upgrade, and cleans up debhelper-related dependencies and formatting in debian/control. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Groveer
approved these changes
Jun 3, 2026
zccrs
approved these changes
Jun 3, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Groveer, wineee, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
treeland.service is managed by DDM at runtime, but the package installs it as a systemd system unit. With the default dh_installsystemd behavior, debhelper generates maintainer script snippets that can start or restart the unit during package install and upgrade. That makes upgrading the treeland package disrupt the active compositor/greeter session.
Override dh_installsystemd with --no-start and --no-stop-on-upgrade so package operations do not change the running treeland.service state. DDM remains responsible for explicitly starting and stopping the compositor.
Also add the missing ${misc:Depends} substitutions and normalize the treeland-dev dependency formatting so debhelper-generated dependencies are preserved in the binary package metadata.
PMS: 364327
Summary by Sourcery
Adjust Debian packaging for treeland to avoid systemd-managed restarts during package install and upgrade and preserve debhelper-generated dependencies in metadata.
Bug Fixes:
Build: