refactor: switch ddm IPC to Qt Remote Objects#926
Open
zccrs wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
zccrs
force-pushed
the
qremoteobject-ddm-ipc
branch
3 times, most recently
from
8e45a63 to
9abb442
Compare
zccrs
commented
Jun 3, 2026
| namespace { | ||
| constexpr auto remoteObjectName = "TreelandDDMRemote"; | ||
| constexpr auto remoteObjectSocketName = "org.deepin.TreelandDDMRemote"; | ||
| constexpr auto ddmServiceCgroup = "/ddm.service"; |
Member
Author
There was a problem hiding this comment.
不用判断service文件或pid，只需要设置好socket文件的权限，只允许root和treeland所在用户访问即可
| } | ||
|
|
||
| wl_global *DDMInterfaceV1Private::global() const | ||
| DDMInterfaceV1Private::DDMInterfaceV1Private(DDMInterfaceV1 *_q) |
Member
Author
There was a problem hiding this comment.
不要复用这个interface文件，很奇怪，搞个新的，旧的删除就行
zccrs
force-pushed
the
qremoteobject-ddm-ipc
branch
2 times, most recently
from
b35594b to
532987b
Compare
Member
Author
|
已按这轮 review 收口：
这轮 force-push 后我会继续盯 CI，确认全部变绿。 |
zccrs
commented
Jun 3, 2026
| set(TREELAND_DDM_REMOTE_SOURCE_HEADER | ||
| ${CMAKE_CURRENT_BINARY_DIR}/rep_treelandddmremote_source.h | ||
| ) | ||
| add_custom_command( |
Member
Author
There was a problem hiding this comment.
为啥用自定义command？怎么不用 qt_add_repc_replicas？
Replace the old DDM Wayland interface with a Qt Remote Objects host and source while keeping the peer validation around the local socket transport. Refresh the commit message body so the branch satisfies the repository commitlint policy after rebasing review feedback.
zccrs
force-pushed
the
qremoteobject-ddm-ipc
branch
from
532987b to
084edb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Testing