-
Notifications
You must be signed in to change notification settings - Fork 42
fix: remove unnecessary left margin from title bar icon #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed Layout.leftMargin: 2 from the title bar icon element. This margin was causing misalignment in the title bar layout and was determined to be unnecessary for proper visual spacing. The icon now aligns correctly without this extra margin, improving the overall layout consistency. Influence: 1. Verify title bar icon alignment in different window states 2. Check layout consistency across various title bar configurations 3. Test with different icon sizes and presence/absence of title text 4. Ensure no visual regression in title bar appearance fix: 移除标题栏图标不必要的左边距 从标题栏图标元素中移除了 Layout.leftMargin: 2。这个边距导致标题栏布局出 现错位,经确定对于正确的视觉间距是不必要的。现在图标在没有这个额外边距的 情况下能够正确对齐,提高了整体布局的一致性。 Influence: 1. 在不同窗口状态下验证标题栏图标对齐 2. 检查各种标题栏配置下的布局一致性 3. 测试不同图标大小和标题文本存在/不存在的情况 4. 确保标题栏外观没有视觉回归 PMS: BUG-335495
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#546
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes an unnecessary left margin on the title bar icon by deleting the Layout.leftMargin: 2 property in TitleBar.qml, ensuring the icon aligns correctly without extra spacing across different window and layout configurations. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review我来对这个git diff进行代码审查:
a) 布局一致性:
b) 代码可维护性:
c) 视觉效果:
d) 潜在风险:
总的来说,这个改动本身很简单,但可能会对界面布局产生连锁影响,建议谨慎处理并做好充分的测试。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#546
Removed Layout.leftMargin: 2 from the title bar icon element. This
margin was causing misalignment in the title bar layout and was
determined to be unnecessary for proper visual spacing. The icon now
aligns correctly without this extra margin, improving the overall layout
consistency.
Influence:
fix: 移除标题栏图标不必要的左边距
从标题栏图标元素中移除了 Layout.leftMargin: 2。这个边距导致标题栏布局出
现错位,经确定对于正确的视觉间距是不必要的。现在图标在没有这个额外边距的
情况下能够正确对齐,提高了整体布局的一致性。
Influence:
PMS: BUG-335495
Summary by Sourcery
Bug Fixes: