Skip to content

fix(webrichtexteditor): add image drag-and-drop validation #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Apr 28, 2026
Merged

fix(webrichtexteditor): add image drag-and-drop validation #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 41 additions & 3 deletions src/views/webrichtexteditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (C) 2019 ~ 2019 UnionTech Software Technology Co.,Ltd.
// Copyright (C) 2019 - 2026 UnionTech Software Technology Co.,Ltd.
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later
Expand Down Expand Up @@ -600,7 +600,26 @@ void WebRichTextEditor::contextMenuEvent(QContextMenuEvent *e)
*/
void WebRichTextEditor::dragEnterEvent(QDragEnterEvent *event)
{
event->acceptProposedAction();
// 只接受图片文件的拖拽（jpg, png, bmp）
if (event->mimeData()->hasUrls()) {
bool hasValidImage = false;
for (const auto &url : event->mimeData()->urls()) {
QString suffix = QFileInfo(url.path()).suffix().toLower();
if (suffix == "jpg" || suffix == "png" || suffix == "bmp") {
hasValidImage = true;
break;
}
}
if (hasValidImage) {
event->acceptProposedAction();
} else {
event->ignore();
}
} else if (event->mimeData()->hasImage()) {
event->acceptProposedAction();
} else {
event->ignore();
}
}

/**
Expand All @@ -620,7 +639,26 @@ void WebRichTextEditor::dragLeaveEvent(QDragLeaveEvent *event)
*/
void WebRichTextEditor::dragMoveEvent(QDragMoveEvent *e)
{
Q_UNUSED(e);
// 只接受图片文件的拖拽（jpg, png, bmp）
if (e->mimeData()->hasUrls()) {
bool hasValidImage = false;
for (const auto &url : e->mimeData()->urls()) {
QString suffix = QFileInfo(url.path()).suffix().toLower();
if (suffix == "jpg" || suffix == "png" || suffix == "bmp") {
hasValidImage = true;
break;
}
}
if (hasValidImage) {
e->acceptProposedAction();
} else {
e->ignore();
}
} else if (e->mimeData()->hasImage()) {
e->acceptProposedAction();
} else {
e->ignore();
}
}

void WebRichTextEditor::dropEvent(QDropEvent *event)
Expand Down
Loading