fix: remove Net_MonitorNotify from Net_GreeterFlags#464
Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom Dec 24, 2025
Merged
fix: remove Net_MonitorNotify from Net_GreeterFlags#464caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Removed Net_MonitorNotify flag from Net_GreeterFlags bitmask definition. This change aligns the greeter flags configuration with the intended functionality by excluding monitoring notification capabilities that are not required for the greeter component. The greeter interface should focus on core network connection management without monitoring features. Influence: 1. Verify greeter interface loads correctly without monitoring notifications 2. Test network connection functionality in greeter mode 3. Confirm no monitoring-related UI elements appear in greeter 4. Check that basic network operations work as expected fix: 从 Net_GreeterFlags 中移除 Net_MonitorNotify 标志 从 Net_GreeterFlags 位掩码定义中移除了 Net_MonitorNotify 标志。此变更使 欢迎界面标志配置与预期功能保持一致,排除了欢迎界面组件不需要的监控通知功 能。欢迎界面应专注于核心网络连接管理,而不包含监控特性。 Influence: 1. 验证欢迎界面在没有监控通知的情况下正确加载 2. 测试欢迎界面模式下的网络连接功能 3. 确认欢迎界面中不出现监控相关的UI元素 4. 检查基本网络操作功能正常 PMS: BUG-345099
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Net_GreeterFlags bitmask to remove the Net_MonitorNotify capability so the greeter only enables core connection-management behavior without monitoring notifications. Class diagram for NetType greeter flag changeclassDiagram
class NetType {
<<enumeration>>
Net_DockFlags
Net_LockFlags
Net_GreeterFlags
Net_DccFlags
}
class Net_DockFlags {
<<bitmask>>
+Net_Device
+Net_VPN
+Net_SysProxy
+Net_Airplane
+Net_AirplaneTips
+Net_VPNTips
+Net_tipsLinkEnabled
+Net_UseSecretAgent
+Net_CheckPortal
+Net_8021xToControlCenterUnderConnect
+Net_autoUpdateHiddenConfig
}
class Net_LockFlags {
<<bitmask>>
+Net_Device
+Net_VPN
+Net_SysProxy
+Net_Airplane
+Net_AirplaneTips
+Net_VPNTips
+Net_UseSecretAgent
+Net_CheckPortal
+Net_8021xSendNotifyUnderConnect
}
class Net_GreeterFlags {
<<bitmask>>
+Net_Device
+Net_Airplane
+Net_AirplaneTips
+Net_ServiceNM
+Net_AutoAddConnection
+Net_UseSecretAgent
+Net_CheckPortal
+Net_8021xSendNotifyUnderConnect
}
class Net_DccFlags {
<<bitmask>>
+Net_Device
+Net_VPN
+Net_VPNChildren
+Net_SysProxy
+Net_Hotspot
+Net_Airplane
+Net_DSL
+Net_Details
}
NetType <|-- Net_DockFlags
NetType <|-- Net_LockFlags
NetType <|-- Net_GreeterFlags
NetType <|-- Net_DccFlags
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个git diff进行代码审查:
改进建议:
这个修改本身看起来是合理的,但建议进行充分的测试以确保不会影响现有功能。 |
mhduiy
approved these changes
Dec 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Net_MonitorNotify flag from Net_GreeterFlags bitmask definition. This change aligns the greeter flags configuration with the intended functionality by excluding monitoring notification capabilities that are not required for the greeter component. The greeter interface should focus on core network connection management without monitoring features.
Influence:
fix: 从 Net_GreeterFlags 中移除 Net_MonitorNotify 标志
从 Net_GreeterFlags 位掩码定义中移除了 Net_MonitorNotify 标志。此变更使 欢迎界面标志配置与预期功能保持一致,排除了欢迎界面组件不需要的监控通知功
能。欢迎界面应专注于核心网络连接管理,而不包含监控特性。
Influence:
PMS: BUG-345099
Summary by Sourcery
Bug Fixes: