ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer tooling and optimize container-based integration tests.

Build:

• Bump tox-lsr dependency from 3.16.0 to 3.17.0 in GitHub workflow scripts.

CI:

• Switch Fedora 43 qemu and container test scenarios to use Ansible Core 2.20 instead of 2.19.
• Optimize container integration test runs by configuring requirements and callback plugin setup to run fully on the first test only and be skipped on subsequent tests.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test matrices, and adjusts container test environment variables to take advantage of the new tox-lsr behavior for faster, clearer container runs.

Flow diagram for ansible_lint_workflow_with_tox_lsr_3_17_0

flowchart TD
  Start["Push_or_PR_to_repository"] --> Checkout["actions_checkout"]
  Checkout --> Setup_Python["Set_up_Python_environment"]
  Setup_Python --> Install_Tox_LSR["pip_install_tox_lsr_3_17_0"]
  Install_Tox_LSR --> Convert_To_Collection["tox_lsr_convert_role_to_collection_format"]
  Convert_To_Collection --> Run_Ansible_Lint["tox_lsr_run_ansible_lint"]
  Run_Ansible_Lint --> Lint_Success{Lint_successful}
  Lint_Success -- Yes --> End_Success["Workflow_success"]
  Lint_Success -- No --> End_Failure["Workflow_failure"]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows.	Update tox-lsr version in qemu-kvm integration workflow installation step. Update tox-lsr version in ansible-lint workflow installation step. Update tox-lsr version in ansible-managed-var-comment workflow installation step. Update tox-lsr version in ansible-test workflow installation step.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Use Ansible 2.20 instead of 2.19 for Fedora 43 QEMU and container matrices.	Change Fedora 43 QEMU matrix entry to use qemu-ansible-core-2-20 environment. Change Fedora 43 container matrix entry to use container-ansible-core-2-20 environment. Change Fedora 43 bootc container matrix entry to use container-ansible-core-2-20 environment.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop environment flags to leverage new tox-lsr container test behavior and speed up subsequent runs.	Remove previous LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides that disabled debug/profile behavior. Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS with false for the first test iteration to ensure full setup initially. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each run so subsequent test plays can skip requirements installation and callback plugin setup.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider adding a short comment or reference explaining the new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS flags (what they control in tox-lsr and why they must be false for the first test and true afterward) to make the intent clearer for future maintainers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a short comment or reference explaining the new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS flags (what they control in tox-lsr and why they must be false for the first test and true afterward) to make the intent clearer for future maintainers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}