ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr tooling and qemu/container tox environment names to remain compatible with newer tox versions.

CI:

• Bump tox-lsr used in GitHub workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environment identifiers in the qemu-kvm integration workflow from dotted to dashed version formats.

Documentation:

• Refresh contributing documentation example to use the new dashed qemu tox environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to work with tox 4.49 by renaming qemu/container tox environment names from dotted ansible-core versions to hyphenated ones, and bumps tox-lsr to 3.16.0 across workflows and documentation.

Sequence diagram for GitHub Actions job running tox with renamed qemu env

sequenceDiagram
  participant GitHubActions
  participant Job_ansible_lint
  participant Pip
  participant Tox_lsr
  participant Tox
  participant QemuEnv

  GitHubActions->>Job_ansible_lint: Trigger workflow ansible-lint
  Job_ansible_lint->>Pip: pip3 install git+https://github.com/linux-system-roles/tox-lsr@3.16.0
  Pip-->>Job_ansible_lint: tox-lsr 3.16.0 installed
  Job_ansible_lint->>Tox_lsr: Invoke tox-lsr entrypoint
  Tox_lsr->>Tox: Run tox with env qemu-ansible-core-2-20
  Tox->>QemuEnv: Create env qemu-ansible-core-2-20
  QemuEnv-->>Tox: Execute qemu tests without python 2.20 conflict
  Tox-->>Tox_lsr: Return test results
  Tox_lsr-->>Job_ansible_lint: Aggregate and report results
  Job_ansible_lint-->>GitHubActions: Mark job success or failure

Loading

File-Level Changes

Change	Details	Files
Rename tox environment identifiers from dotted to hyphenated ansible-core version format to avoid tox 4.49 misinterpreting them as Python versions.	Update qemu matrix env names from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y in the QEMU KVM integration workflow. Update container matrix env names from container-ansible-core-X.Y to container-ansible-core-X-Y in the QEMU KVM integration workflow. Adjust inline example tox command in contributing documentation to use the new qemu-ansible-core-X-Y environment naming convention.	.github/workflows/qemu-kvm-integration-tests.yml contributing.md
Upgrade tox-lsr version used in CI workflows to 3.16.0.	Change tox-lsr install version from 3.15.0 to 3.16.0 in the qemu-kvm-integration-tests workflow. Change tox-lsr install version from 3.15.0 to 3.16.0 in the ansible-lint workflow. Change tox-lsr install version from 3.15.0 to 3.16.0 in the ansible-managed-var-comment workflow. Change tox-lsr install version from 3.15.0 to 3.16.0 in the ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining the tox-lsr version (3.16.0) in a single reusable location (e.g., a workflow env or reusable workflow) so future version bumps don't require editing multiple files.
• The example in contributing.md now references qemu-ansible-core-2-20, but the workflow matrix only defines up to 2-19; consider aligning the documented example with an actually configured environment to avoid confusion.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining the tox-lsr version (3.16.0) in a single reusable location (e.g., a workflow env or reusable workflow) so future version bumps don't require editing multiple files.
- The example in contributing.md now references `qemu-ansible-core-2-20`, but the workflow matrix only defines up to `2-19`; consider aligning the documented example with an actually configured environment to avoid confusion.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}