Conversation
Add Fedora 43, remove Fedora 41 from Testing Farm CI Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Testing Farm GitHub Actions workflow to drop Fedora 41 from CI and start testing on Fedora 43, including adjusting the supported platforms discovery logic and the test matrix with appropriate Ansible versions. Flow diagram for updated Fedora matrix selection in Testing Farm CIflowchart TD
A[Start workflow tft.yml] --> B[Set meta_main to meta_main_yml]
B --> C{galaxy_tags contains fedora}
C -->|yes| D[Add Fedora_42 to supported_platforms]
D --> E[Add Fedora_43 to supported_platforms]
C -->|no| F[Do not add Fedora_42_or_Fedora_43]
E --> G[Define test matrix]
F --> G
G --> H[Matrix entry Fedora_42 with ansible_2_19]
G --> I[Matrix entry Fedora_43 with ansible_2_20]
G --> J[Matrix entry CentOS_7_latest with ansible_2_9]
G --> K[Matrix entry CentOS_Stream_8]
H --> L[Run Testing Farm job]
I --> L
J --> L
K --> L
L --> M[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The Fedora versions are currently defined in two places (the
supported_platformsconstruction and the matrixincludelist); consider centralizing the Fedora/Ansible mapping (e.g., via a reusable job or a shared config block) to avoid divergence on future updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Fedora versions are currently defined in two places (the `supported_platforms` construction and the matrix `include` list); consider centralizing the Fedora/Ansible mapping (e.g., via a reusable job or a shared config block) to avoid divergence on future updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Fedora 43, remove Fedora 41 from Testing Farm CI
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: