refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#128
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 in collection-requirements to maintain compatibility with EL7, while leaving other collection constraints unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of pinning ansible.posix to exactly 2.1.0, consider expressing this as a version range (e.g., ">=2.1.0,<2.2.0") to preserve compatibility with EL7 while still allowing patch-level updates within the compatible series.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of pinning ansible.posix to exactly 2.1.0, consider expressing this as a version range (e.g., ">=2.1.0,<2.2.0") to preserve compatibility with EL7 while still allowing patch-level updates within the compatible series.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
9f5999c to
5d5a328
Compare
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request adds an explicit version constraint to the ChangesAnsible Collection Version Pinning
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
5d5a328 to
6b3a1cb
Compare
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
6b3a1cb to
6179c71
Compare
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.