Skip to content

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#332

Merged
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0
May 20, 2026
Merged

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#332
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0

Conversation

@richm
Copy link
Copy Markdown
Collaborator

@richm richm commented May 18, 2026

The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Summary by CodeRabbit

  • Chores
    • Updated ansible.posix collection version constraint to enforce a specific compatible version range, ensuring consistent dependency resolution across environments.

Review Change Stack

@richm richm requested review from rjeffman and spetrosi as code owners May 18, 2026 21:23
@richm richm self-assigned this May 18, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins the ansible.posix collection dependency to version 2.1.0 to maintain compatibility with EL7 while leaving other collection requirements unchanged.

File-Level Changes

Change Details Files
Pin ansible.posix collection to a specific version compatible with EL7.
  • Add an explicit version constraint 2.1.0 for the ansible.posix collection in the collection requirements metadata
  • Keep the existing version range for community.general unchanged
meta/collection-requirements.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm force-pushed the ansible-posix-2.1.0 branch from b79d100 to 1a15b0b Compare May 19, 2026 13:57
@richm richm changed the title refactor: use ansible.posix 2.1.0 for EL7 compatability refactor: use ansible.posix 2.1.X for EL7 compatibility May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f2bc5d52-10c6-46fc-9186-282ccaf6d9d3

📥 Commits

Reviewing files that changed from the base of the PR and between 63881b5 and a3e091f.

📒 Files selected for processing (1)
  • meta/collection-requirements.yml

📝 Walkthrough

Walkthrough

Adds an explicit version constraint '>=2.1.0,<2.2.0' to the ansible.posix collection entry in meta/collection-requirements.yml.

Changes

ansible.posix version constraint

Layer / File(s) Summary
Add ansible.posix version constraint
meta/collection-requirements.yml
The ansible.posix collection entry now includes the explicit version constraint version: '>=2.1.0,<2.2.0'.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete; it lacks the required template structure with 'Enhancement', 'Reason', 'Result', and 'Issue Tracker Tickets' sections. Restructure the description to follow the template format with explicit sections: Enhancement, Reason, Result, and Issue Tracker Tickets, organizing the existing information accordingly.
Description Format ⚠️ Warning PR description does not follow required template format. Missing "Enhancement:" or "Feature:", "Reason:", and "Result:" section headers as defined in .github/pull_request_template.md. Reformat PR description to include required section headers: Enhancement:, Reason:, Result:, and optional Issue Tracker Tickets sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title follows Conventional Commits format with 'refactor' type and clearly describes the main change: pinning ansible.posix to 2.1.X for EL7 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
meta/collection-requirements.yml (1)

5-5: ⚡ Quick win

Consider adding a lower bound for precision.

The constraint <2.2.0 correctly excludes the problematic 2.2.0 release, but it allows any older version including potentially untested ones. For consistency with the community.general entry (line 7) and to better match the PR's stated intent of using 2.1.x, consider using a range constraint:

📌 Proposed refinement
-    version: <2.2.0
+    version: '>=2.1.0,<2.2.0'

This ensures only 2.1.x versions are used, matching the PR description's intent and following the pattern used for other collections.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@meta/collection-requirements.yml` at line 5, The version constraint currently
set as "<2.2.0" allows older, untested releases; update the "version" value in
meta/collection-requirements.yml to restrict to the 2.1.x series (for example
">=2.1.0,<2.2.0") so it matches the PR intent and the pattern used for the
community.general entry; change the value associated with the version key
accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@meta/collection-requirements.yml`:
- Line 5: The version constraint currently set as "<2.2.0" allows older,
untested releases; update the "version" value in
meta/collection-requirements.yml to restrict to the 2.1.x series (for example
">=2.1.0,<2.2.0") so it matches the PR intent and the pattern used for the
community.general entry; change the value associated with the version key
accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c013048-8cff-493e-a3fa-b04233ca809f

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe3253 and 1a15b0b.

📒 Files selected for processing (1)
  • meta/collection-requirements.yml

@richm richm force-pushed the ansible-posix-2.1.0 branch from 1a15b0b to 63881b5 Compare May 19, 2026 15:38
@richm richm changed the title refactor: use ansible.posix 2.1.X for EL7 compatibility refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip] May 20, 2026
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency.  Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the ansible-posix-2.1.0 branch from 63881b5 to a3e091f Compare May 20, 2026 13:42
@richm richm merged commit 118631f into main May 20, 2026
13 checks passed
@richm richm deleted the ansible-posix-2.1.0 branch May 20, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant