refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#332
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 to maintain compatibility with EL7 while leaving other collection requirements unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
b79d100 to
1a15b0b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds an explicit version constraint Changesansible.posix version constraint
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
meta/collection-requirements.yml (1)
5-5: ⚡ Quick winConsider adding a lower bound for precision.
The constraint
<2.2.0correctly excludes the problematic 2.2.0 release, but it allows any older version including potentially untested ones. For consistency with thecommunity.generalentry (line 7) and to better match the PR's stated intent of using 2.1.x, consider using a range constraint:📌 Proposed refinement
- version: <2.2.0 + version: '>=2.1.0,<2.2.0'This ensures only 2.1.x versions are used, matching the PR description's intent and following the pattern used for other collections.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@meta/collection-requirements.yml` at line 5, The version constraint currently set as "<2.2.0" allows older, untested releases; update the "version" value in meta/collection-requirements.yml to restrict to the 2.1.x series (for example ">=2.1.0,<2.2.0") so it matches the PR intent and the pattern used for the community.general entry; change the value associated with the version key accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@meta/collection-requirements.yml`:
- Line 5: The version constraint currently set as "<2.2.0" allows older,
untested releases; update the "version" value in
meta/collection-requirements.yml to restrict to the 2.1.x series (for example
">=2.1.0,<2.2.0") so it matches the PR intent and the pattern used for the
community.general entry; change the value associated with the version key
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c013048-8cff-493e-a3fa-b04233ca809f
📒 Files selected for processing (1)
meta/collection-requirements.yml
1a15b0b to
63881b5
Compare
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
63881b5 to
a3e091f
Compare
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.
Summary by CodeRabbit