Skip to content

completions: fix ocp plugin command list and description#3385

Open
jimmunn wants to merge 1 commit into
linux-nvme:masterfrom
Micron-TPG-OSS:fix-ocp-completion
Open

completions: fix ocp plugin command list and description#3385
jimmunn wants to merge 1 commit into
linux-nvme:masterfrom
Micron-TPG-OSS:fix-ocp-completion

Conversation

@jimmunn
Copy link
Copy Markdown
Contributor

@jimmunn jimmunn commented May 21, 2026

Fix bash completion for the ocp plugin:

  • Correct "clear-pcie-correctable-error-counters" to "clear-pcie-correctable-errors"
  • Correct "vs-fw-activate-history" to "fw-activate-history"
  • Add missing commands: error-recovery-log, unsupported-reqs-log, tcg-configuration-log, set-plp-health-check-interval, get-plp-health-check-interval, get-enable-ieee1667-silo, set-enable-ieee1667-silo, persistent-event-log, get-idle-wakeup-time
  • Add "version" and "help" commands

Also fix the misleading description for get-clear-pcie-correctable-errors in ocp-nvme.h to clarify it retrieves the feature value rather than clearing the counters.

Fix bash completion for the ocp plugin:
- Correct "clear-pcie-correctable-error-counters" to
  "clear-pcie-correctable-errors"
- Correct "vs-fw-activate-history" to "fw-activate-history"
- Add missing commands: error-recovery-log, unsupported-reqs-log,
  tcg-configuration-log, set-plp-health-check-interval,
  get-plp-health-check-interval, get-enable-ieee1667-silo,
  set-enable-ieee1667-silo, persistent-event-log, get-idle-wakeup-time
- Add "version" and "help" commands

Also fix the misleading description for get-clear-pcie-correctable-errors
in ocp-nvme.h to clarify it retrieves the feature value rather than
clearing the counters.

Signed-off-by: Jim Munn <jlmunn@micron.com>
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented May 28, 2026

Could you also update the zsh binding (_nvme) to stay in sync? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants