fabrics: avoid segfault at sanitize_discovery_log_entry()#3376
Open
martin-gpy wants to merge 1 commit into
Open
fabrics: avoid segfault at sanitize_discovery_log_entry()#3376martin-gpy wants to merge 1 commit into
martin-gpy wants to merge 1 commit into
Conversation
Avoid a potential segfault at sanitize_discovery_log_entry() while dereferencing the nvmf_disc_log_entry pointer. Signed-off-by: Martin George <marting@netapp.com>
igaw
reviewed
May 28, 2026
| struct nvmf_disc_log_entry *e) | ||
| { | ||
| if (!e) | ||
| return; |
Collaborator
There was a problem hiding this comment.
Did you observe a crash? I don't see how this is potential possible. All call side pass in &log->entries[i]. So this will be always a pointer value which is != NULL.
I don't mind starting to sanity check the log page input (all input is evil) but this seems at the wrong place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a potential segfault at sanitize_discovery_log_entry() while dereferencing the nvmf_disc_log_entry pointer.