always use 64-bit for timevals#68
Merged
marckleinebudde merged 1 commit intolinux-can:masterfrom May 18, 2025
Merged
Conversation
On 32bits platforms compiled with _TIME_BITS=64 %lu/%ld fails to print / read the timestamps correctly. Always use %llu/%lld with (un)signed long long instead. The sign follows the existing formatters, as in unsigned for reading, signed for writing.
Contributor
Author
|
can this be merged? Then I can upstream an OE recipe for it without patches. |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32bits platforms compiled with _TIME_BITS=64 %lu/%ld fails to print / read the timestamps correctly. Always use %llu/%lld with (un)signed long long instead. The sign follows the existing formatters, as in unsigned for reading, signed for writing.
Note: we only use the rx timestamps in raw mode and that is the only thing tested. The compiler complains about the other instances, so it is included as well.