Fix wasmJs browser tests and switch core to Node.js#40
Merged
Conversation
kotlinx.io.files.Path requires Node.js APIs (require('os')) that are
unavailable in ChromeHeadless browser tests. Switch core module from
disabled browser tests to nodejs() and add wasmJsNodeTest CI step.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
DownloadRequest.directory is now String? (nullable) and DownloadState.Completed.filePath is now String, removing the kotlinx.io dependency from the api module. PathSerializer moved to core module (internal) for TaskRecord persistence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
linroid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kotlinx.io.files.PathwithStringin theapimodule so it no longer depends onkotlinx-io, fixing wasmJs browser test crashes (Pathcallsrequire('os')which is unavailable in ChromeHeadless)DownloadRequest.directoryis nowString?(nullable);DownloadState.Completed.filePathis nowStringPathSerializertocoremodule (internal) forTaskRecordpersistencelibrary/corewasmJs target frombrowsertonodejs()since core still useskotlinx-iointernallywasmJsBrowserTestandwasmJsNodeTestCI stepsTest plan
./gradlew :library:api:wasmJsBrowserTestpasses./gradlew :library:api:jvmTestpasses./gradlew :library:core:jvmTestpasses./gradlew :library:core:wasmJsNodeTestpasses./gradlew :library:sqlite:jvmTestpasses./gradlew :server:testpasseswasmJsBrowserTestandwasmJsNodeTestsuccessfully🤖 Generated with Claude Code