Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Dec 17, 2025

LinodeGo PR that supports this feature: linode/linodego#867

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.62%. Comparing base (ab91991) to head (89b82d1).

Files with missing lines Patch % Lines
cloud/linode/loadbalancers.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   73.72%   73.62%   -0.10%     
==========================================
  Files          19       19              
  Lines        2835     2840       +5     
==========================================
+ Hits         2090     2091       +1     
- Misses        504      508       +4     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +765 to +772
switch linodego.NodeBalancerPlanType(typeStr) {
case linodego.NBTypeCommon: // need to add this because of the golint check
return linodego.NBTypeCommon
case linodego.NBTypePremium:
return linodego.NBTypePremium
case linodego.NBTypePremium40GB:
return linodego.NBTypePremium40GB
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to warn when the annotation is an invalid type instead of just silently defaulting to the default NBType?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we could warn and then just default to basic NB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants