Debug reserver ip #506
Draft
Debug reserver ip #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for configuring NodeBalancer frontend VPC placement via service annotations. This enables NodeBalancers to be deployed with private frontend addresses within a VPC. New annotations: - linode-loadbalancer-frontend-ipv4-range: Explicit IPv4 CIDR - linode-loadbalancer-frontend-ipv6-range: Explicit IPv6 CIDR - linode-loadbalancer-frontend-vpc-name: VPC name for resolution - linode-loadbalancer-frontend-subnet-name: Subnet name for resolution - linode-loadbalancer-frontend-subnet-id: Direct subnet ID Resolution precedence: 1. IPv4/IPv6 Range annotations (explicit CIDR) 2. VPC/Subnet name annotations (name-based resolution) 3. Subnet ID annotation (direct ID) Key behavioral difference from backend VPC implementation: - Frontend VPC is opt-in: returns nil when no annotations are present, resulting in no frontend VPC configuration - Backend VPC is always configured: falls through precedence levels and always returns VPC options using the service's default subnet ID This design allows frontend VPC to remain an optional feature while backend VPC continues to be mandatory for NodeBalancer operation. Includes: - CIDR validation for IPv4 and IPv6 ranges - Name-to-ID resolution requiring both vpc-name and subnet-name - Unit tests for validation, status generation, and option building - Debug logging for frontend VPC NodeBalancers
- Change annotation precedence order: subnet-id first, then vpc-name/subnet-name, then optional IP ranges - Consolidate IPv4/IPv6 validation into single validateNodeBalancerFrontendIPRange function - Simplify getFrontendVPCCreateOptions to reduce code duplication and improve readability - Make IP range annotations optional when subnet is specified - Add error when IP ranges are provided without subnet selector - Update tests to cover more senarios
- Document new frontend VPC annotations: frontend-subnet-id, frontend-vpc-name, frontend-subnet-name, frontend-ipv4-range, frontend-ipv6-range - Document backend-subnet-id annotation - Add detailed frontend VPC configuration section explaining annotation precedence and usage - Update backend VPC annotation examples to use correct backend-vpc-name and backend-subnet-name prefixes - Add reference to vpc-frontend-example.yaml in examples
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 73.72% 73.69% -0.03%
==========================================
Files 19 19
Lines 2835 2885 +50
==========================================
+ Hits 2090 2126 +36
- Misses 504 511 +7
- Partials 241 248 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…et-name annotations. Change annotation check from OR to AND logic for vpc-name and subnet-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines: