Skip to content

feat: clean up pvc after pipelinerun #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merll merged 11 commits into from
May 28, 2026
+12 −6
Merged

feat: clean up pvc after pipelinerun #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15e6a20
feat: remove pvc after pipelinerun
merll May 27, 2026
2bfac1a
chore: move istio sidecar exemption to label
merll May 27, 2026
fdbb5ca
Merge branch 'main' into APL-1897
merll May 27, 2026
8d031ac
feat: do not inject istio into affinity assistant
merll May 27, 2026
936cd9a
test: reattempt push
merll May 27, 2026
d504bb3
Merge branch 'main' into APL-1897
merll May 27, 2026
91e80f6
Merge branch 'main' into APL-1897
svcAPLBot May 28, 2026
379b920
Merge branch 'main' into APL-1897
svcAPLBot May 28, 2026
885b142
Merge branch 'main' into APL-1897
svcAPLBot May 28, 2026
b76932f
Merge branch 'main' into APL-1897
svcAPLBot May 28, 2026
fe18a7a
revert: remove label default without effect
merll May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions charts/team-ns/templates/builds/buildpack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,11 @@ spec:
generateName: buildpacks-build-{{ .name }}-
labels:
tekton.dev/pipeline: buildpacks-build-{{ .name }}
sidecar.istio.io/inject: "false"
{{- include "team-ns.chart-labels" $ | nindent 10 }}
annotations:
sidecar.istio.io/inject: "false"
argocd.argoproj.io/compare-options: IgnoreExtraneous
tekton.dev/auto-cleanup-pvc: "true"
Comment thread
j-zimnowoda marked this conversation as resolved.
spec:
pipelineRef:
name: buildpacks-build-{{ .name }}
Expand Down Expand Up @@ -149,11 +150,13 @@ kind: PipelineRun
metadata:
name: buildpacks-build-{{ .name }}
annotations:
sidecar.istio.io/inject: "false"
argocd.argoproj.io/compare-options: IgnoreExtraneous
# ArgoCD sync wave annotation to ensure it's applied after the pipeline
argocd.argoproj.io/sync-wave: "5"
labels: {{- include "team-ns.chart-labels" $ | nindent 4 }}
tekton.dev/auto-cleanup-pvc: "true"
Comment thread
j-zimnowoda marked this conversation as resolved.
labels:
sidecar.istio.io/inject: "false"
{{- include "team-ns.chart-labels" $ | nindent 4 }}
spec:
pipelineRef:
name: buildpacks-build-{{ .name }}
Expand Down
9 changes: 6 additions & 3 deletions charts/team-ns/templates/builds/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,11 @@ spec:
generateName: docker-trigger-build-{{ .name }}-
labels:
tekton.dev/pipeline: docker-build-{{ .name }}
sidecar.istio.io/inject: "false"
{{- include "team-ns.chart-labels" $ | nindent 10 }}
annotations:
sidecar.istio.io/inject: "false"
argocd.argoproj.io/compare-options: IgnoreExtraneous
tekton.dev/auto-cleanup-pvc: "true"
Comment thread
j-zimnowoda marked this conversation as resolved.
spec:
pipelineRef:
name: docker-build-{{ .name }}
Expand Down Expand Up @@ -149,11 +150,13 @@ kind: PipelineRun
metadata:
name: docker-build-{{ .name }}
annotations:
sidecar.istio.io/inject: "false"
argocd.argoproj.io/compare-options: IgnoreExtraneous
# ArgoCD sync wave annotation to ensure it's applied after the pipeline
argocd.argoproj.io/sync-wave: "5"
labels: {{- include "team-ns.chart-labels" $ | nindent 4 }}
tekton.dev/auto-cleanup-pvc: "true"
Comment thread
j-zimnowoda marked this conversation as resolved.
labels:
sidecar.istio.io/inject: "false"
{{- include "team-ns.chart-labels" $ | nindent 4 }}
spec:
pipelineRef:
name: docker-build-{{ .name }}
Expand Down