Skip to content

feat: add apiToken handling to external-dns-raw template#2917

Merged
j-zimnowoda merged 20 commits into
linode:mainfrom
vaheed:main
May 28, 2026
Merged

feat: add apiToken handling to external-dns-raw template#2917
j-zimnowoda merged 20 commits into
linode:mainfrom
vaheed:main

Conversation

@vaheed
Copy link
Copy Markdown
Contributor

@vaheed vaheed commented Feb 5, 2026

📌 Summary

Fixes a template bug in external-dns-raw.gotmpl where the Cloudflare provider references
.apiSecret, which is not defined in the Helm values schema. The correct field is .apiToken.

Why this is needed

When External-DNS is enabled with Cloudflare, otomi apply fails during Helm values rendering:
executing "stringTemplate" at <.apiSecret>: map has no entry for key "apiSecret"

Related issue

Fixes #2916

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Comment thread values/external-dns/external-dns-raw.gotmpl Outdated
Comment thread values/external-dns/external-dns-raw.gotmpl
@merll
Copy link
Copy Markdown
Collaborator

merll commented Feb 9, 2026

Thank you for the report @vaheed and for the PR. Both apiSecret and apiToken exist in the schema, for allowing for both authentication methods to CloudFlare supported by external-dns. Using one or the other value is used to determine which variables to set.

Of course the template rendering should not fail if either of the values is missing. My suggestions above should fix this issue.

Co-authored-by: merll <merll@users.noreply.github.com>
@j-zimnowoda j-zimnowoda changed the title Add apiToken handling to external-dns-raw template feat: add apiToken handling to external-dns-raw template Feb 19, 2026
@j-zimnowoda j-zimnowoda enabled auto-merge (squash) May 28, 2026 08:26
@j-zimnowoda j-zimnowoda disabled auto-merge May 28, 2026 08:29
@j-zimnowoda j-zimnowoda merged commit dcd829a into linode:main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix/external-dns-cloudflare-api-token

4 participants