Merged
Conversation
…rove internal Gitea handling
…checksums for credentials
Contributor
|
Comparison of Helm chart templating output: @@ data.giteaPassword @@
# v1/Secret/apl-gitea-operator/apl-gitea-operator-secret
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ spec.template.metadata @@
! + one map entry added:
+ annotations:
+ # Restart pod when git credentials or config changes (important for migration)
+ checksum/git-credentials: cca965a8824cc32153ec28b2a259b856cf7a97fd1c41b1ada29474d4f2bf8bff
+ checksum/git-config: 42222a02649e732ca3ce292c87cbc4bc66622c96cb4588c7c1f517d8c23d3aa9
@@ spec.template.spec.containers.apl-operator @@
! + one map entry added:
+ envFrom:
+ - secretRef:
+ name: apl-sops-secrets
+ - secretRef:
+ name: apl-git-credentials
@@ stringData @@
# v1/Secret/apl-operator/gitea-credentials
! ± type change from map to <nil>
- GIT_USERNAME: otomi-admin
GIT_PASSWORD: giteaAdminPassword
+ <nil>
@@ (root level) @@
# v1/Secret/apl-git-credentials
! + one document added:
+ ---
+ type: Opaque
+ # Source: apl-operator/templates/secrets.yaml
+ apiVersion: v1
+ kind: Secret
+ metadata:
+ name: apl-git-credentials
+ stringData:
+ username: otomi-admin
+ password: gitPasswordForTesting
@@ data.password @@
# v1/Secret/argocd/argocd-repo-creds-gitea
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data.password @@
# v1/Secret/argocd/argocd-repo-creds-gitea-internal
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data.password @@
# v1/Secret/gitea-admin-secret
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data.GIT_REPO_URL @@
! ± value change
- http://gitea-http.gitea.svc.cluster.local:3000/otomi/values
+ http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git
@@ data.GIT_EMAIL @@
! ± value change
- bm90QHVzLmVk
+ cGlwZWxpbmVAY2x1c3Rlci5sb2NhbA==
@@ data.GIT_PASSWORD @@
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ spec.workspaces.git-credentials.secret.secretName @@
# tekton.dev/v1/PipelineRun/docker-build-demo-java1-v0-0-1
! ± value change
- gitea-credentials
+ apl-git-credentials
@@ apps.gitea @@
! - two map entries removed:
- adminUsername: otomi-admin
- adminPassword: giteaAdminPassword
@@ apps.otomi-api @@
! - one map entry removed:
- git:
- email: some@secret.value
- user: someuser
- password: somesecretvalue
@@ otomi @@
! + one map entry added:
+ git:
+ branch: main
+ repoUrl: "http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git"
+ username: otomi-admin
+ email: pipeline@cluster.local
+ password: gitPasswordForTesting
|
This was referenced Feb 12, 2026
merll
reviewed
Feb 13, 2026
merll
approved these changes
Feb 13, 2026
Ani1357
approved these changes
Feb 13, 2026
Contributor
Ani1357
left a comment
There was a problem hiding this comment.
LGTM. Tested by deploying a new cluster using this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only merge with:
📌 Summary
🔍 Reviewer Notes
🧹 Checklist