Skip to content

fix: update notification receivers logic in teams #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferruhcihan wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −3
Open

fix: update notification receivers logic in teams #797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79ffec5
fix: update notification receivers logic in teams
ferruhcihan May 28, 2026
dfb36aa
Merge remote-tracking branch 'origin/main' into APL-1871
svcAPLBot May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pages/teams/create-edit/TeamsCreateEditPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,11 @@ export default function TeamsCreateEditPage({
* alertManager needs to be configured with 'receivers: null' if there are no recievers and 'none' is currently
* the way to configure that.
*/
const rawReceivers = submitData.spec?.alerts?.receivers ?? []
let receivers = rawReceivers.filter((r) => r !== 'none')
let receivers: ('slack' | 'msteams' | 'none')[] = []
if (submitData.spec?.alerts?.slack?.url) receivers.push('slack')
if (submitData.spec?.alerts?.msteams?.lowPrio || submitData.spec?.alerts?.msteams?.highPrio)
receivers.push('msteams')

// @ts-ignore: no receivers requires 'none' string
if (submitData.spec?.managedMonitoring?.alertmanager && receivers.length === 0) receivers = ['none']

// 3) Combine edge cases with submittedData for final payload
Expand Down